Various cleanups and speedups for the Vhosts plugin #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- $uri only used once so replaced usage with $req->request_uri
- $map_name was incorrect description for var contents
- moved $vhost definition to just before it starts being used
- removed needless $vhost empty checks
- replaced A; while (X) { A; } with do { A; } while (X);
- moved comments next to actual code
- add spacing
|
I removed the "Decrease overall CPU usage by 20% when using the vhost plugin." line as doing performance testing on my development box showed it to be more like 3%. The big drop in CPU usage on the live server must have been from something else.. |
Conflicts: CHANGES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few changes here but each change is in a separate commit.. Other than one pure cleanup commit, the others are as follows (copied from CHANGELOG):
I'm not a perl programmer but even I know the vhost_selector optimization isn't very perl. Turning the closure into a static function was a lot faster (probably around 15%) but taking out the function call altogether is faster again. Yes, I could probably use a do { } while (0); and break out of it if need be, but I think gotos are more legible in this case... Just pre-empting the "WTF?!" ;)
Everything else should be pretty straight forward.